chore: update proxy handling order

changed setRcloneProxy to default to user's proxy first.
This commit is contained in:
Fenopy
2025-12-15 06:14:03 -06:00
committed by GitHub
parent 44df1666f4
commit 15f0c1ee72

View File

@@ -357,18 +357,10 @@ namespace AndroidSideloader
private static void setRcloneProxy() private static void setRcloneProxy()
{ {
// Use DNS fallback proxy if active, otherwise use user's proxy settings // Use the user's proxy settings if set, otherwise fallback to DNS fallback proxy if active
string proxyUrl = DnsHelper.ProxyUrl; string proxyUrl = DnsHelper.ProxyUrl;
if (!string.IsNullOrEmpty(proxyUrl)) if (settings.useProxy)
{
// Use our DNS-resolving proxy
rclone.StartInfo.EnvironmentVariables["HTTP_PROXY"] = proxyUrl;
rclone.StartInfo.EnvironmentVariables["HTTPS_PROXY"] = proxyUrl;
rclone.StartInfo.EnvironmentVariables["http_proxy"] = proxyUrl;
rclone.StartInfo.EnvironmentVariables["https_proxy"] = proxyUrl;
}
else if (settings.useProxy)
{ {
// Use user's configured proxy // Use user's configured proxy
var url = $"http://{settings.ProxyAddress}:{settings.ProxyPort}"; var url = $"http://{settings.ProxyAddress}:{settings.ProxyPort}";
@@ -377,6 +369,14 @@ namespace AndroidSideloader
rclone.StartInfo.EnvironmentVariables["http_proxy"] = url; rclone.StartInfo.EnvironmentVariables["http_proxy"] = url;
rclone.StartInfo.EnvironmentVariables["https_proxy"] = url; rclone.StartInfo.EnvironmentVariables["https_proxy"] = url;
} }
else if (!string.IsNullOrEmpty(proxyUrl))
{
// Use our DNS-resolving proxy
rclone.StartInfo.EnvironmentVariables["HTTP_PROXY"] = proxyUrl;
rclone.StartInfo.EnvironmentVariables["HTTPS_PROXY"] = proxyUrl;
rclone.StartInfo.EnvironmentVariables["http_proxy"] = proxyUrl;
rclone.StartInfo.EnvironmentVariables["https_proxy"] = proxyUrl;
}
else else
{ {
// No proxy // No proxy
@@ -388,3 +388,4 @@ namespace AndroidSideloader
} }
} }
} }