From 013081475fcdeb5d2a075751993c20821cd29eba Mon Sep 17 00:00:00 2001
From: Christian Benincasa <chrisbenincasa@gmail.com>
Date: Thu, 9 Apr 2026 11:36:20 -0400
Subject: [PATCH] refactor: log full error when subtitle download fails

---
 .../src/stream/ExternalSubtitleDownloader.ts  |  3 ++-
 server/src/stream/plex/PlexStreamDetails.ts   | 22 +------------------
 2 files changed, 3 insertions(+), 22 deletions(-)

diff --git a/server/src/stream/ExternalSubtitleDownloader.ts b/server/src/stream/ExternalSubtitleDownloader.ts
index e93c2d41..73108149 100644
--- a/server/src/stream/ExternalSubtitleDownloader.ts
+++ b/server/src/stream/ExternalSubtitleDownloader.ts
@@ -69,7 +69,8 @@ export class ExternalSubtitleDownloader {
 
       if (subtitlesRes.isFailure()) {
         this.logger.warn(
-          'Error while requesting external subtitle stream from Jellyfin: %s',
+          subtitlesRes.error,
+          'Error while requesting external subtitle stream: %s',
           subtitlesRes.error.message ?? '',
         );
         return;
diff --git a/server/src/stream/plex/PlexStreamDetails.ts b/server/src/stream/plex/PlexStreamDetails.ts
index adf7eb56..0696105f 100644
--- a/server/src/stream/plex/PlexStreamDetails.ts
+++ b/server/src/stream/plex/PlexStreamDetails.ts
@@ -474,6 +474,7 @@ export class PlexStreamDetails extends ExternalStreamDetailsFetcher<PlexT> {
 
           this.logger.warn(
             'Skipping external subtitles at index %d because download failed. Please check logs and file an issue for assistance.',
+            stream.index ?? -1,
           );
 
           return;
@@ -536,25 +537,4 @@ export class PlexStreamDetails extends ExternalStreamDetailsFetcher<PlexT> {
 
     return streamDetails;
   }
-
-  // private getPlexTranscodeStreamUrl(key: string) {
-  //   const query = querystring.encode({
-  //     ...DefaultPlexHeaders,
-  //     'X-Plex-Token': this.server.accessToken,
-  //     Connection: 'keep-alive',
-  //     path: key,
-  //     mediaIndex: 0,
-  //     partIndex: 0,
-  //     fastSeek: 1,
-  //     directPlay: true,
-  //     directStream: true,
-  //     directStreamAudio: true,
-  //     copyts: false,
-  //   });
-
-  //   return `${trimEnd(
-  //     this.server.uri,
-  //     '/',
-  //   )}/video/:/transcode/universal/start.m3u8?${query}`;
-  // }
 }