clocksource: Don't use non-continuous clocksources as watchdog

Using a non-continuous aka untrusted clocksource as a watchdog for another
untrusted clocksource is equivalent to putting the fox in charge of the
henhouse.

That's especially true with the jiffies clocksource which depends on
interrupt delivery based on a periodic timer. Neither the frequency of that
timer is trustworthy nor the kernel's ability to react on it in a timely
manner and rearm it if it is not self rearming.

Just don't bother to deal with this. It's not worth the trouble and only
relevant to museum piece hardware.

Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Link: https://patch.msgid.link/20260123231521.858743259@kernel.org
This commit is contained in:
Thomas Gleixner
2026-01-24 00:17:57 +01:00
parent 79ccb0693a
commit 1432f9d4e8

View File

@@ -651,6 +651,13 @@ static void clocksource_select_watchdog(bool fallback)
if (cs->flags & CLOCK_SOURCE_MUST_VERIFY)
continue;
/*
* If it's not continuous, don't put the fox in charge of
* the henhouse.
*/
if (!(cs->flags & CLOCK_SOURCE_IS_CONTINUOUS))
continue;
/* Skip current if we were requested for a fallback. */
if (fallback && cs == old_wd)
continue;