bybrooklyn/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-05 23:05:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

ASoC: SDCA: Update externally_requested flag to cover all requests

Browse Source 
Currently there is a flag to indicate if an IRQ has been requested by
something outside the SDCA core, such that the core can skip requesting
that IRQ. However, it is simpler and more useful to always store the
allocated IRQ number. This will allow the core to see if the IRQ has
been requested, to perform additional operations on the IRQ, and
request IRQs in multiple phases.

Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
Link: https://patch.msgid.link/20251020155512.353774-7-ckeepax@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Charles Keepax
2025-10-20 16:54:59 +01:00
committed by Mark Brown
parent 390c05f47d
commit 56bbda23d4
2 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
include/sound/sdca_interrupts.h
View File

@@ -29,9 +29,8 @@ struct sdca_function_data;
* @entity: Pointer to the Entity that the interrupt is associated with.
* @control: Pointer to the Control that the interrupt is associated with.
* @priv: Pointer to private data for use by the handler.
* @externally_requested: Internal flag used to check if a client driver has
* already requested the interrupt, for custom handling, allowing the core to
* skip handling this interrupt.
* @irq: IRQ number allocated to this interrupt, also used internally to track
* the IRQ being assigned.
*/
struct sdca_interrupt {
const char *name;
@@ -44,7 +43,7 @@ struct sdca_interrupt {
void *priv;
bool externally_requested;
int irq;
};
/**

8
sound/soc/sdca/sdca_interrupts.c
View File

@@ -262,6 +262,8 @@ static int sdca_irq_request_locked(struct device *dev,
if (ret)
return ret;
info->irqs[sdca_irq].irq = irq;
dev_dbg(dev, "requested irq %d for %s\n", irq, name);
return 0;
@@ -301,8 +303,6 @@ int sdca_irq_request(struct device *dev, struct sdca_interrupt_info *info,
return ret;
}
info->irqs[sdca_irq].externally_requested = true;
return 0;
}
EXPORT_SYMBOL_NS_GPL(sdca_irq_request, "SND_SOC_SDCA");
@@ -379,9 +379,9 @@ int sdca_irq_populate(struct sdca_function_data *function,
interrupt = &info->irqs[irq];
if (interrupt->externally_requested) {
if (interrupt->requested) {
dev_dbg(dev,
"skipping irq %d, externally requested\n",
"skipping irq %d, already requested\n",
irq);
continue;
}