mirror of
https://github.com/torvalds/linux.git
synced 2026-04-18 06:44:00 -04:00
drbd: use genl pre_doit/post_doit
Every doit handler followed the same pattern: stack-allocate an adm_ctx, call drbd_adm_prepare() at the top, call drbd_adm_finish() at the bottom. This duplicated boilerplate across 25 handlers and made error paths inconsistent, since some handlers could miss sending the reply skb on early-exit paths. The generic netlink framework already provides pre_doit/post_doit hooks for exactly this purpose. An old comment even noted "this would be a good candidate for a pre_doit hook". Use them: - pre_doit heap-allocates adm_ctx, looks up per-command flags from a new drbd_genl_cmd_flags[] table, runs drbd_adm_prepare(), and stores the context in info->user_ptr[0]. - post_doit sends the reply, drops kref references for device/connection/resource, and frees the adm_ctx. - Handlers just receive adm_ctx from info->user_ptr[0], set reply_dh->ret_code, and return. All teardown is in post_doit. - drbd_adm_finish() is removed, superseded by post_doit. Signed-off-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com> Link: https://patch.msgid.link/20260324152907.2840984-1-christoph.boehmwalder@linbit.com Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
committed by
Jens Axboe
parent
829def1e35
commit
630bbba45c
File diff suppressed because it is too large
Load Diff
@@ -292,6 +292,10 @@ static struct genl_family ZZZ_genl_family __ro_after_init = {
|
||||
#endif
|
||||
.maxattr = ARRAY_SIZE(CONCATENATE(GENL_MAGIC_FAMILY, _tla_nl_policy))-1,
|
||||
.policy = CONCATENATE(GENL_MAGIC_FAMILY, _tla_nl_policy),
|
||||
#ifdef GENL_MAGIC_FAMILY_PRE_DOIT
|
||||
.pre_doit = GENL_MAGIC_FAMILY_PRE_DOIT,
|
||||
.post_doit = GENL_MAGIC_FAMILY_POST_DOIT,
|
||||
#endif
|
||||
.ops = ZZZ_genl_ops,
|
||||
.n_ops = ARRAY_SIZE(ZZZ_genl_ops),
|
||||
.mcgrps = ZZZ_genl_mcgrps,
|
||||
|
||||
Reference in New Issue
Block a user