bybrooklyn/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-04-18 06:44:00 -04:00
Code Issues Packages Projects Releases Wiki Activity

module: Simplify warning on positive returns from module_init()

Browse Source 
It should now be rare to trigger this warning - it doesn't need to be so
verbose. Make it follow the usual style in the module loading code.

For the same reason, drop the dump_stack().

Suggested-by: Petr Pavlu <petr.pavlu@suse.com>
Signed-off-by: Lucas De Marchi <demarchi@kernel.org>
Reviewed-by: Aaron Tomlin <atomlin@atomlin.com>
Reviewed-by: Petr Pavlu <petr.pavlu@suse.com>
Reviewed-by: Daniel Gomez <da.gomez@samsung.com>
Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
This commit is contained in:
Lucas De Marchi
2026-03-30 08:13:52 -05:00
committed by Sami Tolvanen
parent 743f8cae54
commit 663385f915
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
kernel/module/main.c
View File

@@ -3115,13 +3115,9 @@ static noinline int do_init_module(struct module *mod)
goto fail_free_freeinit;
}
if (ret > 0) {
pr_warn("%s: '%s'->init suspiciously returned %d, it should "
"follow 0/-E convention\n"
"%s: loading module anyway...\n",
__func__, mod->name, ret, __func__);
dump_stack();
}
if (ret > 0)
pr_warn("%s: init suspiciously returned %d, it should follow 0/-E convention\n",
mod->name, ret);
/* Now it's a first class citizen! */
mod->state = MODULE_STATE_LIVE;