mirror of
https://github.com/torvalds/linux.git
synced 2026-05-03 22:12:32 -04:00
fb8421a94c
Devlink features were introduced to disallow devlink reload calls of userspace before the devlink was fully initialized. The reason for this workaround was the fact that devlink reload was originally called without devlink instance lock held. However, with recent changes that converted devlink reload to be performed under devlink instance lock, this is redundant so remove devlink features entirely. Note that mlx5 used this to enable devlink reload conditionally only when device didn't act as multi port slave. Move the multi port check into mlx5_devlink_reload_down() callback alongside with the other checks preventing the device from reload in certain states. Signed-off-by: Jiri Pirko <jiri@nvidia.com> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
131 lines
3.4 KiB
C
131 lines
3.4 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/* Copyright (c) 2021 Hisilicon Limited. */
|
|
|
|
#include <net/devlink.h>
|
|
|
|
#include "hclgevf_devlink.h"
|
|
|
|
static int hclgevf_devlink_info_get(struct devlink *devlink,
|
|
struct devlink_info_req *req,
|
|
struct netlink_ext_ack *extack)
|
|
{
|
|
#define HCLGEVF_DEVLINK_FW_STRING_LEN 32
|
|
struct hclgevf_devlink_priv *priv = devlink_priv(devlink);
|
|
char version_str[HCLGEVF_DEVLINK_FW_STRING_LEN];
|
|
struct hclgevf_dev *hdev = priv->hdev;
|
|
|
|
snprintf(version_str, sizeof(version_str), "%lu.%lu.%lu.%lu",
|
|
hnae3_get_field(hdev->fw_version, HNAE3_FW_VERSION_BYTE3_MASK,
|
|
HNAE3_FW_VERSION_BYTE3_SHIFT),
|
|
hnae3_get_field(hdev->fw_version, HNAE3_FW_VERSION_BYTE2_MASK,
|
|
HNAE3_FW_VERSION_BYTE2_SHIFT),
|
|
hnae3_get_field(hdev->fw_version, HNAE3_FW_VERSION_BYTE1_MASK,
|
|
HNAE3_FW_VERSION_BYTE1_SHIFT),
|
|
hnae3_get_field(hdev->fw_version, HNAE3_FW_VERSION_BYTE0_MASK,
|
|
HNAE3_FW_VERSION_BYTE0_SHIFT));
|
|
|
|
return devlink_info_version_running_put(req,
|
|
DEVLINK_INFO_VERSION_GENERIC_FW,
|
|
version_str);
|
|
}
|
|
|
|
static int hclgevf_devlink_reload_down(struct devlink *devlink,
|
|
bool netns_change,
|
|
enum devlink_reload_action action,
|
|
enum devlink_reload_limit limit,
|
|
struct netlink_ext_ack *extack)
|
|
{
|
|
struct hclgevf_devlink_priv *priv = devlink_priv(devlink);
|
|
struct hclgevf_dev *hdev = priv->hdev;
|
|
struct hnae3_handle *h = &hdev->nic;
|
|
struct pci_dev *pdev = hdev->pdev;
|
|
int ret;
|
|
|
|
if (test_bit(HCLGEVF_STATE_RST_HANDLING, &hdev->state)) {
|
|
dev_err(&pdev->dev, "reset is handling\n");
|
|
return -EBUSY;
|
|
}
|
|
|
|
switch (action) {
|
|
case DEVLINK_RELOAD_ACTION_DRIVER_REINIT:
|
|
rtnl_lock();
|
|
ret = hdev->nic_client->ops->reset_notify(h, HNAE3_DOWN_CLIENT);
|
|
if (ret) {
|
|
rtnl_unlock();
|
|
return ret;
|
|
}
|
|
|
|
ret = hdev->nic_client->ops->reset_notify(h,
|
|
HNAE3_UNINIT_CLIENT);
|
|
rtnl_unlock();
|
|
return ret;
|
|
default:
|
|
return -EOPNOTSUPP;
|
|
}
|
|
}
|
|
|
|
static int hclgevf_devlink_reload_up(struct devlink *devlink,
|
|
enum devlink_reload_action action,
|
|
enum devlink_reload_limit limit,
|
|
u32 *actions_performed,
|
|
struct netlink_ext_ack *extack)
|
|
{
|
|
struct hclgevf_devlink_priv *priv = devlink_priv(devlink);
|
|
struct hclgevf_dev *hdev = priv->hdev;
|
|
struct hnae3_handle *h = &hdev->nic;
|
|
int ret;
|
|
|
|
*actions_performed = BIT(action);
|
|
switch (action) {
|
|
case DEVLINK_RELOAD_ACTION_DRIVER_REINIT:
|
|
rtnl_lock();
|
|
ret = hdev->nic_client->ops->reset_notify(h, HNAE3_INIT_CLIENT);
|
|
if (ret) {
|
|
rtnl_unlock();
|
|
return ret;
|
|
}
|
|
|
|
ret = hdev->nic_client->ops->reset_notify(h, HNAE3_UP_CLIENT);
|
|
rtnl_unlock();
|
|
return ret;
|
|
default:
|
|
return -EOPNOTSUPP;
|
|
}
|
|
}
|
|
|
|
static const struct devlink_ops hclgevf_devlink_ops = {
|
|
.info_get = hclgevf_devlink_info_get,
|
|
.reload_actions = BIT(DEVLINK_RELOAD_ACTION_DRIVER_REINIT),
|
|
.reload_down = hclgevf_devlink_reload_down,
|
|
.reload_up = hclgevf_devlink_reload_up,
|
|
};
|
|
|
|
int hclgevf_devlink_init(struct hclgevf_dev *hdev)
|
|
{
|
|
struct pci_dev *pdev = hdev->pdev;
|
|
struct hclgevf_devlink_priv *priv;
|
|
struct devlink *devlink;
|
|
|
|
devlink =
|
|
devlink_alloc(&hclgevf_devlink_ops,
|
|
sizeof(struct hclgevf_devlink_priv), &pdev->dev);
|
|
if (!devlink)
|
|
return -ENOMEM;
|
|
|
|
priv = devlink_priv(devlink);
|
|
priv->hdev = hdev;
|
|
hdev->devlink = devlink;
|
|
|
|
devlink_register(devlink);
|
|
return 0;
|
|
}
|
|
|
|
void hclgevf_devlink_uninit(struct hclgevf_dev *hdev)
|
|
{
|
|
struct devlink *devlink = hdev->devlink;
|
|
|
|
devlink_unregister(devlink);
|
|
|
|
devlink_free(devlink);
|
|
}
|